Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create pull_request_template.md #168

Merged
4 commits merged into from
Sep 26, 2023
Merged

Create pull_request_template.md #168

4 commits merged into from
Sep 26, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 13, 2023 •
edited by ghost
Loading

@ghost ghost requested review from rocktavious and davidbloss September 13, 2023 21:58
@ghost ghost self-assigned this Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Merging #168 (093c2be) into main (c9c2b4a) will not change coverage.
Report is 15 commits behind head on main.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #168   +/-   ##
=====================================
  Coverage   6.22%   6.22%           
=====================================
  Files          5       5           
  Lines        257     257           
=====================================
  Hits          16      16           
  Misses       241     241

see 2 files with indirect coverage changes

@ghost ghost requested a review from davidbloss September 14, 2023 23:09
@ghost
Copy link
Author

ghost commented Sep 14, 2023

made changes based on suggestions, let me know what you all think @davidbloss @rocktavious

davidbloss
davidbloss approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@davidbloss davidbloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link
Author

ghost commented Sep 25, 2023

@davidbloss @rocktavious I made a change to this PR so that the template is now 5 sections 3 sections. Filling out 5 whole sections after pushing changes and testing locally is a chore. As time goes on we can expand it into more sections if we really need to.

davidbloss
davidbloss approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@davidbloss davidbloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ghost ghost merged commit 712e122 into main Sep 26, 2023
5 checks passed
@ghost ghost deleted the taimoor-at-opslevel-patch-1 branch September 26, 2023 15:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rocktavious @davidbloss